Update themes #1662
Merged
Update themes #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets remove these sets, the theme should set those properties for us.
Know AngualrTicks, Labels and needle Needle are themed instead of hard-coded.
|
Is there an option to only apply the theme changes to the labels and tooltips but leave the chart colors the same? I'm color blind and I have a hard time distinguishing between the pastel colors used in the dark theme. The original chart colors stood out fine in the dark theme and it was easier to distinguish between them. |
|
Try #1240 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library has changed a lot, there are multiple outdated objects where themes are not applied.
What does this PR do?
This PR updates the dark and light themes, fixes issues in PolarCharts, Legends, and VisualElements.
What it does not
LiveCharts themes must be handled manually, every supported UI framework uses different techniques to detect/apply themes, the developer must handle that according to the target framework (See installation guide in the web site).
Some screen shots